feat: migrate heatmap, horizon, iframe and markup #367
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/835l2kbpg |
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 51.20% 47.22% -3.98%
==========================================
Files 126 139 +13
Lines 2695 2922 +227
Branches 394 403 +9
==========================================
Hits 1380 1380
- Misses 1286 1513 +227
Partials 29 29
Continue to review full report at Codecov.
|
kristw
changed the title
| test: /\.jsx?$/, | ||
| use: config.module.rules[0].use, | ||
| }); | ||
|
|
||
| config.module.rules.push({ |
There was a problem hiding this comment.
This rule only applies to typescript. but there are older packages that are jsx.
| .register(); | ||
| ``` | ||
|
|
||
| Then use it via `SuperChart`. See [storybook](https://apache-superset.github.io/superset-ui-plugins/?selectedKind=plugin-chart-horizon) for more details. |
There was a problem hiding this comment.
These storybook links would also need an update. But we can probably do it in a batch later.
There was a problem hiding this comment.
Sounds good. I'll focus on making them compile and storybook work first.
Bumps [@airbnb/lunar](https://github.com/airbnb/lunar) from 2.63.1 to 2.64.0. - [Release notes](https://github.com/airbnb/lunar/releases) - [Commits](https://github.com/airbnb/lunar/compare/@airbnb/lunar@2.63.1...@airbnb/lunar@2.64.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
🏆 Enhancements
heatmap,horizon,iframeandmarkupplugin